GitHub addresses not parsed correctly

Matt's Avatar

Matt

16 Jun, 2011 08:29 PM

Pasting this:
https://user@github.com/company/repo.git

Produces this:
user@github.com/company/repo.git"target="_blank">https://user@github.com/company/repo.git

With the email-looking parts linked.

  1. Support Staff 1 Posted by trevor on 17 Jun, 2011 06:25 PM

    trevor's Avatar

    Hi Matt,

    thanks for taking the time to bring this up.

    Unfortunately it's a function of how Campfire's javascript processes the messages you 'speak' locally (you can see that in action if you do the same test within Safari).

    It looks like they are doing multiple independent passes through the message, looking for items to autolink and potentially clobbering the result of a prior autolink.

    Thankfully, everyone else that sees your message will get the correct link though. So while it's annoying, your message is being correctly communicated.

    I'll be honest - I'm not likely to address this problem in Propane 1 because the fix would require tampering with the Campfire javascript after it comes down from the server - something I try to avoid as much as possible.

    Propane 2 (still in development) doesn't suffer from this particular issue.

    Sorry I don't have an immediate fix for you.

    Regards, Trev

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac