Growl notifications display incorrectly for multi-line messages

iconmaster's Avatar

iconmaster

19 Feb, 2009 04:12 PM

Propane does not handle Growl notifications well for messages which wrap across multiple lines. Only the last part of the message is shown.

Compare the following to what is shown in the attached Growl notification image: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Phasellus blandit tellus sed nibh. Aliquam erat volutpat. Nunc vel ante. Fusce vehicula ligula ac orci semper iaculis. Curabitur volutpat rhoncus sapien. Phasellus convallis pharetra pede. Maecenas ut magna sed est rhoncus suscipit. Vivamus vel tellus. Cras eleifend sagittis arcu. Proin laoreet felis at sem. Aliquam scelerisque sem pellentesque nunc. Nam tempus tellus vitae sapien.

While the notification can't contain everything in a message like that, defaulting to the last part of the message just leaves a nonsense fragment. If anything, Propane should try to fit as much as possible starting from the first word of the message.

  1. Support Staff 1 Posted by trevor on 19 Feb, 2009 11:43 PM

    trevor's Avatar

    Hi,

    thanks for pointing this out. It's not that Propane is truncating the string on purpose - what you've uncovered is (what appears to be) a bug in the regular expression library I'm using.

    Before I send the message to growl I do what should be the ruby equivalent of gsub(/\s+/, ' ') to convert any newlines or consecutive whitespace characters into a single space character. It seems that the regex library is messing this up for longer strings.

    I've changed it to a more brute-force way of trimming and joining whitespace and your 'Lorem' example gets through unmangled. The change will appear in the next Propane update (before the end of the month).

    Thanks for reporting this.

    Trev

  2. 2 Posted by iconmaster on 20 Feb, 2009 01:48 AM

    iconmaster's Avatar

    Awesome, thanks!

  3. Support Staff 3 Posted by trevor on 28 Feb, 2009 12:14 AM

    trevor's Avatar

    Hey,

    I just released the fix for this - check for updates.

    Regards, Trev

  4. trevor closed this discussion on 28 Feb, 2009 12:14 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac